Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is there duplicated code? #11

Open
DerCooleVonDem opened this issue Mar 19, 2024 · 2 comments
Open

Why is there duplicated code? #11

DerCooleVonDem opened this issue Mar 19, 2024 · 2 comments

Comments

@DerCooleVonDem
Copy link

ext-vanillagenerator/lib/generator/ground/GroundGenerator.cpp

Line 51 in abd059f

groundMatId = groundMaterial->GetStateId();

@DerCooleVonDem
Copy link
Author

The same state id is stored above?

@larryTheCoder
Copy link
Member

It seems that groundMatId should be a type id instead of state id. However this doesn't seem to have any negative effects towards the vanilla world generation. I will try to do more testing on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@larryTheCoder @DerCooleVonDem