-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to open details panel if cluster property not defined #32
Comments
This would be an easy fix, you would just have to check if the node has clusters or not on https://github.com/Netflix/vizceral-example/blob/master/src/components/detailsPanelNode.jsx#L53. I'd happily review a PR with the fix. As for it being in the vizceral wiki, the clusters property is not something vizceral cares about, it's only used in the side panel is the example. It shows extra metadata that can be surfaced in the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that even in the simple sample data the details panel will not open for any non-internet node. The problem is the code assumes the cluster property is always there on a node (badge: this.state.clusters.length). While in the example it is not. Also noticed the cluster property is not even defined in the main vizceral wiki (should also be updated if possible).
After I added an empty cluster property to my nodes, I can open the details pane. But I still see some strange behavior - the incoming and outgoing sections get collapsed back on each data update. If you have frequent data updates, it is very annoying as it continuously closes.
The text was updated successfully, but these errors were encountered: