-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for AIMDLimit to grow by a configurable amount #147
Comments
@elandau any thoughts? |
also, it looks like when combined with windowed, it might not work well with bursty load because of this condition Line 98 in 5ae2be4
during lower load, limit won't grow, but previously this limit could've been pessimised and there has to be some mechanism to try to increase it am I thinking in a right direction? How to deal with bursty load in that situation? I assume some sort of queueing should be applied then, but am I missing something crucial? Maybe just smaller window size would solve that 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When AIMD works in conjunction with windowed limit, it might be way too careful in growing back after bursty spike (and, therefore, a backoff), because it has to proceed
window size
requests, before increasing limit by 1My proposal is to add new method to AIMDLimit Builder, e.g.
defaulting to 1 (current behavior)
The text was updated successfully, but these errors were encountered: