New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate GradientLimit? #135

Open

udaysagar2177 opened this issue Jul 10, 2019 · 0 comments

udaysagar2177 commented Jul 10, 2019

GradientLimit is very similar to Gradient2Limit except for few minor things and looks like GradientLimit needs some fixes, such as:

-            estimatedLimit = Math.max(minLimit, queueSize);
+            estimatedLimit = Math.max(minLimit, Math.min(maxLimit, queueSize));
...
-        newLimit = Math.max(queueSize, Math.min(maxLimit, newLimit));
+        newLimit = Math.max(minLimit, Math.min(maxLimit, newLimit));

And those from this PR: #134.

With all these fixes, GradientLimit will be exactly equal to Gradient2Limit except for the probeInterval.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment