Fix some bug risks and code quality issues #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: - (anti-pattern) Replace unnecessary function calls to `dict()` and `list()` with literals - (bug-risk) Replace calls to `exit()` with `sys.exit()` - (anti-pattern) Remove unnecessary lambda expression Also added `.deepsource.toml` to configure continuous static analysis with DeepSource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
I'm the founder of DeepSource, a code review automation tool that detects problems in every PR using static analysis and helps developers save a ton of time during code reviews. I ran our analysis on this project and found some interesting issues. I've already fixed some of them in this PR. Here are some others that you might find interesting:
Here are some of the fixes I've made in the PR:
dict()andlist()with literalsexit()withsys.exit()I would love it if you use DeepSource for running continuous analysis on the project. It's free for open-source and detects 550+ issues in Python. All you need to do is follow these simple steps:
Finally, please LMK if you have any questions that I can answer. Looking forward to seeing DeepSource running on aardvark! 🙌
Best,
Sanket.