Accept write_timeout configuration, and supply it along to savoy #587
Conversation
|
looks great, thanks! |
|
@nevinera looks like CI was not passing on this, could you open up a new PR with all tests passing? I think you'll need to do a savon version check because not all versions support this option. |
|
@iloveitaly - definitely, I didn't realize how far back the support reached. Looks like |
…ng to savoy (NetSweet#587)"" This reverts commit f43ead8.
|
@iloveitaly - what is the preferable experience for an engineer that attempts to set the My instinct is to raise a custom exception like UnsupportedConfiguration explaining the issue as part of |
* Revert "Revert "Accept write_timeout configuration, and supply it along to savoy (#587)"" This reverts commit f43ead8. * Extract savon_params as a variable for manipulation * extract Configuration#savon_params and test it directly * Only supply and allow setting write_timeout when Savon supports it * These tests need to execute against both old and new versions of Savon Which means we can't actually instantiate the connection when _pretending_ to have a recent savon version, or we'll trick our own compatibility checks into passing Savon parameters it doesn't support.
The default timeout for reading from netsuite in the gem's configuration is 60 seconds, and the 'open' timeout can be set, but the 'write' timeout was not settable, and defaulted to 0.25 seconds.
Allow the write-timeout to be configured, and supply it to Savoy alongside the read and open timeouts.