-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need a working extension #2
Comments
I'm not sure if this project will get natively integrated into the wix toolset project. It shouldn't prevent you from using this extension though. I'm using this in my wxs file without issues:
A sample WiX project can be found here: https://github.com/NerdyDuck/WixJsonExtension/tree/46023d86c81d2a21cd44c479fd2da0e69a1fee5e/TestJsonConfigInstaller |
How can I do not if I do not have a Visual Studio 2017? |
You can download Visual Studio 2017 here. |
Any chance this can be precompiled in the project? So I can drop the DLL into the Wix Folder and can use it? |
does not compile on visual Studio 2017 15.9.27 |
precompiled dll would be nice :-) |
For fixes to the code, please see pull request #1 which is from a fork of this repo. |
@icnocop (sorry for the very late tag, I have been stuck on this for days now) Should the pull request work just as is? I can get it to compile but the appsettings.json file it installs does not change any values (I have the same product.wxs as the sample project). I am wondering if there is something I need to do to get this to work as expected |
@impojr I recommend creating a verbose MSI log as it may contain detailed information about the reason why you're experiencing the unexpected behavior. |
I know this is old and looks like there have been no updates recently, I'm having the same issue. Project builds and I see output in verbose log after the install, but no values are changed. |
I'm not sure why your JSON file is not being updated. Are the values displayed in the msi log file expected? Can you log the results to the msi log file? For example, I don't see anything logged after the last "Updating..." message. Is the file read-only? Are you able to attach the debugger to the msiexec process to debug the custom action? There's another fork of this project which seems to disable WOW64 redirection if that could be the issue in your case: Have you validated the JSON path works in another application or using different code? |
I tried this with included Test Project as well, it didn't update the json there either. It's possible that dll didn't get compiled correctly (I built it with VS2019). I don't work in Visual Studio, so had to install it only for compiling the dll, which is unfortunate. Having precompiled working dll would be very nice. Will try your suggestion to use a forked project addressing WOW64 redirection next. |
I need to change JSON files in vscodium/vscode/azuredatastudio installations and other products I maintain. Therefore I need to alter product.json file. This extension seems to be able to do this task. I have seen it was committed first 3 years ago and one person is working on it...
How soon can I integrate this into my existing wix 3.x projects?
Are you planing to create a pull to wix toolset project to get this added?
The text was updated successfully, but these errors were encountered: