Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to skip validation on archive model registration #4

Open
luislew opened this issue Apr 12, 2018 · 0 comments
Open

Provide option to skip validation on archive model registration #4

luislew opened this issue Apr 12, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@luislew
Copy link
Contributor

luislew commented Apr 12, 2018

Issue by luislew
Wednesday Feb 21, 2018 at 21:37 GMT
Originally opened as https://github.com/NerdWallet/nwpy-savage/issues/7


Currently, SavageModelMixin.register(archive_table, engine) calls the _validate methods of both the model and archive model. These model class validations rely on an existing DB engine, which may not be desirable if registration is done during application startup. Adding a validate kwarg to the register method would allow end users to skip this validation (and thus avoid needing an active DB connection).

@luislew luislew added the enhancement New feature or request label Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant