TPControl plugin: tp mode "ask" sometimes does not ask

[totemo]

I believe that this is caused by invalidation of the Player object retained by class User:
https://github.com/NerdNu/TPControl/blob/master/src/nu/nerd/tpcontrol/User.java#L17
when the request recipient relogs, dies or transitions between worlds.

I know from my experience working on CutePvP that I was not able to keep Player instances around because they were invalidated by those kinds of occurences. The code that sends the teleport request is otherwise fairly mundane and I can't see how it would go wrong.

As discussed in the forums (https://nerd.nu/forums/index.php?/topic/1832-tp-issue-on-c/#entry13540), I recommend redeclaring the player field as a String.

I can submit a patch for this, but I'm holding off on a point of etiquette, which is that I have stood down as a tech, so I'm not sure whether I'm supposed to still be able to directly push to the repo or whether you would prefer that I submit a pull request. Please advise.

[Deaygo]

I would be fine if you submitted a pull request. But instead of name if you'd be able to use uuid. But, the user class should be removed on logout and not retain anything if I recall correctly. I'd have to look at the code to make sure.

edit: I was wrong about being removed on disconnect. But yes, I think that it should be changed to use UUID instead of username, including the file storage.

[LadyCailin]

A PR is fine. Code reviews are a good thing either way ^_^

On Mar 31, 2014, at 3:49, totemo [email protected] wrote:

I believe that this is caused by invalidation of the Player object retained by class User:
https://github.com/NerdNu/TPControl/blob/master/src/nu/nerd/tpcontrol/User.java#L17
when the request recipient relogs, dies or transitions between worlds.

I know from my experience working on CutePvP that I was not able to keep Player instances around because they were invalidated by those kinds of occurences. The code that sends the teleport request is otherwise fairly mundane and I can't see how it would go wrong.

As discussed in the forums (https://nerd.nu/forums/index.php?/topic/1832-tp-issue-on-c/#entry13540), I recommend redeclaring the player field as a String.

I can submit a patch for this, but I'm holding off on a point of etiquette, which is that I have stood down as a tech, so I'm not sure whether I'm supposed to still be able to directly push to the repo or whether you would prefer that I submit a pull request. Please advise.

—
Reply to this email directly or view it on GitHub.

[totemo]

But instead of name if you'd be able to use uuid.

Sure. I read about Bukkit's deprecation of various methods yesterday.