Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceling an amend still sends a commit #439

Closed
ttytm opened this issue Jan 28, 2023 · 2 comments · Fixed by #1039
Closed

Canceling an amend still sends a commit #439

ttytm opened this issue Jan 28, 2023 · 2 comments · Fixed by #1039
Labels
bug Something isn't working

Comments

@ttytm
Copy link
Contributor

ttytm commented Jan 28, 2023

Description

I would like to be able to cancel amending to the last commit and do not have it commited anyway.

Especially while amending it's important to have cancellation working, as it can get time consuming to restore the previous state.

For now, I quit the editor(lol 🥲 ) if I enter a commit amend dialog and want to stop the amend process.

Neovim version

stable v0.8.x | nightly

Operating system and version

Linux

Steps to reproduce

Trigger commit amend in neogit ca then e.g., q to quit.

Expected behavior

Commit won't get amended when just quitting without saving / confirming.

Actual behavior

Commit amend happens anyway.

Minimal config

-
@ttytm ttytm added the bug Something isn't working label Jan 28, 2023
@ttytm ttytm changed the title Cancel amend commits anyway Canceling an amend still sends a commit Jan 30, 2023
@ten3roberts
Copy link
Member

Does this issue still happen?

@ttytm
Copy link
Contributor Author

ttytm commented Jul 15, 2023

I'm using #441 since months as it also solves this.

But it still does happen checking back on current master 36ffabb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants