-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status buffer closes abruptly after refresh on giant repo #1472
Comments
There's an "auto_show_console" config option - try setting it to false. I suspect whats going on is the popup is stealing focus, but the status buffer needs focus to refresh correctly. |
I tried it and sadly it doesn't seem to help. The console is not being shown, but the behaviour is the same – once the refresh is over the status buffer is closed with an error. After inspecting the logs I've noticed that the Also I am attaching the log file |
I checked out the linux kernel and got a good reproduction, so I'll use that as a performance benchmark and see what I can do :) |
Figured out two things:
with those two things done, I can load the status buffer for the linux repo in about 2~3 seconds. Also check out https://git-scm.com/docs/git-maintenance to automate this :) |
Hey! I tried both steps and in the end it doesn't help. The status buffer is still automatically closed even when the console is disabled. Also I don't mind the slow performance -- the repo is giant, I'm fine with that. The main problem for me is that the buffer is closed abruptly and then on top of that I cannot issue a new status refresh since the previous one is assumed to be running. I can try and investigate the things further if you give me some pointers. |
Description
Hey!
I am working on a giant monorepo and the status buffer is sadly not usable. So far I have noticed several issues:
When I open the status buffer in the new tab, the refresh process is triggered. On my repo it's a longer one, so a popup is shown. As soon as all the commands are run in the popup, it is closed automatically, but this also immediately closes the status buffer
Often this it shows an error message
Invalid buffer id: X
. Sometimes the error message isBuffer X does not exist
This never happens on a smaller projects
I will be happy to help you with figuring this out and can provide the logs if necessary
Thanks in advance!
Neovim version
NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1724512491
Operating system and version
macOS 14.2.1
Steps to reproduce
One obvious way is to clone a giant repo, for instance the Linux kernel, and try to open the status buffer in a new tab there.
I suspect there's a way to trigger the same behaviour in any repository by artificially inserting a timeout when running the git commands, but I am not familiar with neogit's source code enough to suggest the change
Expected behavior
Status buffer being slow, but usable
Actual behavior
Status buffer closing with an error message immediately after the refresh
Minimal config
The text was updated successfully, but these errors were encountered: