This repository has been archived by the owner on Nov 10, 2021. It is now read-only.
Dynamically determine DNS via getprop net.dns #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statically specifying cloudflare's server maybe problematic if you have internal DNS with internal hostnames. This PR uses android's getprop feature to create the DNS resolv.conf entry dynamically. The caveat is that if the DNS server changes while during a session (disconnect, reconnect elsewhere), there might be an issue. Could add a fallback DNS to 1.1.1.1 in those cases?
|
|
|
@Neo-Oli it works on Android 9 without root |
|
But how about android below 9? didn't you take care about it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statically specifying cloudflare's server maybe problematic if you have internal DNS with internal hostnames. This PR uses android's getprop feature to create the DNS resolv.conf entry dynamically.
The caveat is that if the DNS server changes while during a session (disconnect, reconnect elsewhere), there might be an issue. Could add a fallback DNS to 1.1.1.1 in those cases?