Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split series over fq_nmod and fq into different files #1929

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Oct 27, 2024

Inlining makes everything a lot more readable (at least for me). Furthermore, it enables us to grep for some flint function and find all places where it is called (of course if all similar places are inlined/unrolled as well).
And it makes the script in #1812 (comment) a lot better in identifying the flint functions that we call from different locations

The corresponding tests are already in different files.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 92.72727% with 120 lines in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (13e29a5) to head (a4a3ca6).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/fq_nmod_rel_series.jl 92.17% 36 Missing ⚠️
src/flint/fq_rel_series.jl 93.66% 29 Missing ⚠️
src/flint/fq_nmod_abs_series.jl 92.49% 28 Missing ⚠️
src/flint/fq_abs_series.jl 92.47% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1929      +/-   ##
==========================================
+ Coverage   87.39%   87.50%   +0.11%     
==========================================
  Files          97       99       +2     
  Lines       35642    36464     +822     
==========================================
+ Hits        31149    31908     +759     
- Misses       4493     4556      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am somewhat wary of increasing code duplication.

On the other hand I understand how it simplifies some tasks.

@fingolfin fingolfin merged commit a2378d0 into Nemocas:master Nov 8, 2024
24 checks passed
@lgoettgens lgoettgens deleted the lg/fq-series branch November 8, 2024 11:14
@lgoettgens
Copy link
Collaborator Author

The long-term goal is of course to reduce the duplication again.
After putting most of the flint calls into small oneline functions, most of the series types should be mostly identical and can then be simplified/deduplicated again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants