Add generic dispatch for ideal_type
#1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/ideal_type
branch
from
6b0ecb0 to
49dfd4c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
- Coverage 88.17% 88.16% -0.01%
==========================================
Files 120 120
Lines 30303 30305 +2
==========================================
Hits 26719 26719
- Misses 3584 3586 +2 ☔ View full report in Codecov by Sentry. |
|
Seems to be not even breaking, great |
|
It can still break older Hecke releases. We don't test that in CI. I'll have a look tomorrow |
|
I don't see how it could break older Hecke release -- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably breaking because Hecke already declares this.
There should be more code and docstrings added, but since we are close to a breaking release I thought it would be sensible to get this tiny breaking bit in now, and worry about the rest later.