Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do we do with the migrations runner in this project? #79

Open
ghost opened this issue Jul 25, 2020 · 4 comments
Open

What do we do with the migrations runner in this project? #79

ghost opened this issue Jul 25, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 25, 2020

Hi,
I found this project and thought I could use it in a project of mine if it was up to date. So I am thinking of updating it to the new Ecto. However since this project includes support for migrations I wonder what should I do about them? Should we just delete the support for migrations or should I create a mix tasks for handling them or something? If I understand things correctly the migration related stuff has been moved to ecto_sql.

Thank you for your wonderful adapter! 👍

@madshargreave
Copy link

I'm interested in this as well

@ghost
Copy link
Author

ghost commented Jul 25, 2020

I'm interested in this as well

In the support of Ecto 3 or in the migrations? I think I am going try to do a pr to fix update to ecto 3 anyway. If you are interested in the support for migrations, I will try to keep them.

@ghost
Copy link
Author

ghost commented Jul 27, 2020

I'm interested in this as well

Apparently there is this. I will just use that for my own needs. https://hexdocs.pm/ecto3_mnesia/Ecto.Adapters.Mnesia.html

@AndrewDryga
Copy link
Member

@August401 I think migrations are still a nice way to organize your database structure so I would try to keep them, which requires us to write tasks similar to the ones in ecto_sql (unfortunately :().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants