Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM and desktop (Linux, macOS, Windows) support #497

Open
sashkent3 opened this issue Jun 27, 2024 · 2 comments
Open

WASM and desktop (Linux, macOS, Windows) support #497

sashkent3 opened this issue Jun 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@sashkent3
Copy link

sashkent3 commented Jun 27, 2024

WebAssembly support for Flutter web has been available on the Flutter stable channel since Flutter 3.22. Please, consider adding WASM support to the package.

The issue currently lies with the intl_phone_number_input dependency which is not WASM compatible.

For anyone who wants to use flutter_login with WASM now, I made a simple fork which purges support for LoginUserType.intlPhone removing the problematic dependency.

@sashkent3 sashkent3 added the enhancement New feature or request label Jun 27, 2024
@sashkent3
Copy link
Author

intl_phone_number_input itself doesn't support WASM (and also desktop platforms) because of a dependency on libphonenumber_plugin which can be easily replaced by a cross-platform dlibphonenumber package. I've opened a PR there which does exactly that.

If I'm not mistaken, intl_phone_number_input is also the only dependency blocking Linux, macOS and Windows support in flutter_login which would also be resolved by the PR.

You can check out a version of flutter_login which uses the PR version here. I'm happy to confirm that both Linux and WASM versions work as expected and pass all tests. I haven't tested macOS and Windows platforms.

@sashkent3 sashkent3 changed the title WASM support WASM and desktop (Linux, macOS, Windows) support Jun 27, 2024
@sashkent3
Copy link
Author

Since v0.8.0 intl_phone_number_input supports both WASM and desktop platforms. It would be great to see this in flutter_login as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant