Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find unlock tx hash matching a used transfer finalization proof #59

Open
paouvrard opened this issue May 17, 2021 · 0 comments
Open

Find unlock tx hash matching a used transfer finalization proof #59

paouvrard opened this issue May 17, 2021 · 0 comments

Comments

@paouvrard
Copy link

We can use eth_getStorageAt to check that a proof was used i.e that the transfer has already been finalized: aurora-is-near/rainbow-bridge-client#37

This works well for checking that a proof was used, but the event emited by unlockToken https://github.com/aurora-is-near/rainbow-token-connector/blob/23b0c3aca6c5755b70cb6117d20c12e9a640fc37/erc20-connector/contracts/ERC20Locker.sol#L67 doesn't allow us to uniquely identify the unlock tx hash which used the proof.

The rainbow-bridge-frontend currently doesn't do this but we would want users to have an etherscan link to the tx which finalized the transfer. Aurora webapp already has the finalization tx hash available.

This feature is only necessary for transfers which a recovered. For regular transfer we know the finalization tx hash since it is broadcasted by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant