Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

near-lib is pointing to the archived dependency #23

Closed
alexauroradev opened this issue Feb 10, 2021 · 3 comments
Closed

near-lib is pointing to the archived dependency #23

alexauroradev opened this issue Feb 10, 2021 · 3 comments
Labels

Comments

@alexauroradev
Copy link

At the moment bridge-token-factory is using near-lib:

near-lib = { git = "https://github.com/ilblackdragon/balancer-near", rev = "a386305c9829d2e5302a78fdc475c8a279fcf6ed"}

The dependency is outdated, @ilblackdragon moved the code here. We need to update the dependency.

@mfornet
Copy link
Contributor

mfornet commented Feb 11, 2021

Moreover, in the README of the new repository you can read:

All contracts are not code reviewed, come as is, have no guarantees.

We should code-review and pin a particular commit, since token-connector is a security critical application.

Another option is to add reference vanilla implementation of Fungible Token to core-contracts where only sound and maintained contracts are kept as suggested in near/near-sdk-rs#289 (comment)

@ilblackdragon
Copy link
Contributor

The code for this library is moving to near-sdk-rs in this PR: near/near-sdk-rs#275

This PR was blocked on fixing simulation. There might be some other blockers there, I'm not sure.
Plus the FT standard will get upgraded to 141 from 21, which means this repo should also upgrade with that change.

@mfornet
Copy link
Contributor

mfornet commented Feb 15, 2021

This will be fixed by removing this dependency when #21 is implemented.

@mfornet mfornet closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants