Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth2-to-Near-relay: improve config parameters #811

Closed
sept-en opened this issue Sep 19, 2022 · 0 comments · Fixed by #825
Closed

Eth2-to-Near-relay: improve config parameters #811

sept-en opened this issue Sep 19, 2022 · 0 comments · Fixed by #825
Assignees
@olga24912
Labels
enhancement relayers rust Pull requests that update Rust code

Comments

@sept-en
Copy link
Contributor

sept-en commented Sep 19, 2022

In Eth2-to-NEAR-relay, network, contract_type, and near_network_id parameters are accepted as generic String types but would be best handled by Rust’s enum types.
@sept-en sept-en added enhancement relayers rust Pull requests that update Rust code labels Sep 19, 2022
@olga24912 olga24912 mentioned this issue Sep 24, 2022
Merged
@sept-en sept-en linked a pull request Oct 23, 2022 that will close this issue
Eth2Near-relay: split relay on a few crates, many improvements #825
Merged
sept-en added a commit that referenced this issue Oct 23, 2022
@olga24912 @sept-en @karim-en
Eth2Near-relay: split relay on a few crates, many improvements (#825)
2230d63 
* Separate `logger`, `eth_rpc_client`, and `Eth2OnNearClient` contract initialization into separate crates
* Check configuration setup for Mainnet: add a verification on init args that it can't be executed in the trustless mode without `bls` verification on Mainnet (#767). 
* Improve config file usage on contract initialization: `validate_updates`, `verify_bls_signatures`, `hashes_gc_threshold`, `max_submitted_blocks_by_account`, `trusted_signer_account_id` fields are set through the config file instead of hardcoded values (#769). 
* Improve configuration of some args: `network`, `contract_type`, and `near_network_id` now use `enum`s instead of `String`s (#811).
* Add messages for unhandled `unwraps()` on relay start-up (#816).

Co-authored-by: Kirill <[email protected]>
Co-authored-by: Karim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olga24912 olga24912

Labels
enhancement relayers rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eth2Near-relay: split relay on a few crates, many improvements Near-One/rainbow-bridge
2 participants
@sept-en @olga24912