Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth2-to-Near-relay: check configuration setup on Mainnet #767

Closed
sept-en opened this issue Jul 31, 2022 · 0 comments · Fixed by #825
Closed

Eth2-to-Near-relay: check configuration setup on Mainnet #767

sept-en opened this issue Jul 31, 2022 · 0 comments · Fixed by #825
Assignees
Labels

Comments

@sept-en
Copy link
Contributor

sept-en commented Jul 31, 2022

As mentioned in #765, the configuration setup verification for Mainnet should also be added as a part of Eth2-to-Near-relay.

@sept-en sept-en added enhancement security relayers rust Pull requests that update Rust code labels Jul 31, 2022
sept-en added a commit that referenced this issue Oct 23, 2022
* Separate `logger`, `eth_rpc_client`, and `Eth2OnNearClient` contract initialization into separate crates
* Check configuration setup for Mainnet: add a verification on init args that it can't be executed in the trustless mode without `bls` verification on Mainnet (#767). 
* Improve config file usage on contract initialization: `validate_updates`, `verify_bls_signatures`, `hashes_gc_threshold`, `max_submitted_blocks_by_account`, `trusted_signer_account_id` fields are set through the config file instead of hardcoded values (#769). 
* Improve configuration of some args: `network`, `contract_type`, and `near_network_id` now use `enum`s instead of `String`s (#811).
* Add messages for unhandled `unwraps()` on relay start-up (#816).

Co-authored-by: Kirill <[email protected]>
Co-authored-by: Karim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants