Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to 32 byte proof hash #250

Open
ailisp opened this issue Aug 4, 2020 · 3 comments
Open

Switch back to 32 byte proof hash #250

ailisp opened this issue Aug 4, 2020 · 3 comments

Comments

@ailisp
Copy link
Contributor

ailisp commented Aug 4, 2020

As reported by 3rd party, 16 byte increase chance of collision, suggestion was to revert to 32 byte hash.
According to author:
tranvictor/ethashproof#7
It need to be at least 128 bits collision resistance, which is 256 bits to SHA2 or 32 bytes

@ailisp ailisp added the P3 label Aug 4, 2020
@MaksymZavershynskyi MaksymZavershynskyi changed the title Switch back to 32 byte proof hash [Minor] Switch back to 32 byte proof hash Aug 20, 2020
@MaksymZavershynskyi
Copy link
Contributor

This is quite challenging, and is blocked by #150 . Setting estimate to 3 assuming #150 is done.

@Ericson2314
Copy link

Ericson2314 commented Nov 12, 2020

You could try reverting https://github.com/tranvictor/ethashproof/pull/5/files as a stop-gap

@alexauroradev alexauroradev changed the title [Minor] Switch back to 32 byte proof hash Switch back to 32 byte proof hash Feb 12, 2021
@k06a
Copy link
Contributor

k06a commented Jan 11, 2022

Collision resistance for looking for existing hash preimage is still 2^128, not 2^64 – it should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants