Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests are not running in Github Actions #61

Open
GearsAD opened this issue Mar 29, 2022 · 4 comments
Open

Unit tests are not running in Github Actions #61

GearsAD opened this issue Mar 29, 2022 · 4 comments

Comments

@GearsAD
Copy link
Contributor

GearsAD commented Mar 29, 2022

No description provided.

@jim-hill-r
Copy link
Contributor

Agreed unit tests should run on every push. Many are integration tests. Those are also important, just thinking through when they should run. Probably only on merge or PR or even nightly?

@dehann
Copy link
Member

dehann commented Mar 31, 2022

Testing on PR and merge seems good to me

@dehann
Copy link
Member

dehann commented Mar 31, 2022

could add on push to main for the odd cases where main is directly updated.

@GearsAD
Copy link
Contributor Author

GearsAD commented Mar 31, 2022

The tests don't actually run though in GitHub, somethings missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dehann @GearsAD @jim-hill-r