Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 1D and Mixture, #87

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Test 1D and Mixture, #87

merged 1 commit into from
Mar 30, 2022

Conversation

dehann
Copy link
Member

@dehann dehann commented Mar 30, 2022

closes #79

@dehann dehann requested a review from GearsAD March 30, 2022 02:55
@dehann dehann added this to the v0.4.0 milestone Mar 30, 2022
@dehann dehann self-assigned this Mar 30, 2022
Copy link

@sam-globus sam-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just curious, why aren't you solving it? Does it solve?

@dehann
Copy link
Member Author

dehann commented Mar 30, 2022

we can add the solve, I was sending solves to make sure it runs through. PPEs came back. Did not triple check the numerics, but PPEs are there and looked right.

I took out the solving because the request is sent and the test closes out while the server is still processing the solve. So seemed excessive to have the test pass while the solve is still ongoing. Hence the doSolve flag, we can just make that true if you think it will help?

@dehann
Copy link
Member Author

dehann commented Mar 30, 2022

Screenshot from 2022-03-29 20-00-25

@NavAbility NavAbility deleted a comment from sam-globus Mar 30, 2022
@dehann
Copy link
Member Author

dehann commented Mar 30, 2022

julia> getVariables(client, context; detail=SUMMARY) .|> x->x["ppes"][1]["suggested"]
4-element Vector{Vector{Any}}:
 [-40.186702018171744]
 [9.711123006149444]
 [9.729649698600467]
 [-0.21231469666968547]

julia> context
Client: User=Guest, Robot=SDKJL1D, Session=TestSession4

@GearsAD
Copy link
Contributor

GearsAD commented Mar 30, 2022

Cool, yep I'd say it's good to go for now (we can refactor further as we improve tests) but LGTM.

Regarding the solve, I'm half and half - the waitForCompletion should wait for a solve, so it will solve before completing. However we're not testing anything from the results, so it's not necessary at the moment. I'd say leave as it is and we can grow the tests as we add more.

@dehann dehann merged commit d4df223 into main Mar 30, 2022
@dehann dehann deleted the 22Q1/test/1dmixture branch March 30, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for 1D and Mixture cases.
3 participants