Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor integration tests into scenarios (e.g. 1D, 2D, etc.) so we can leverage representative cases for testing. #81

Open
GearsAD opened this issue Mar 27, 2022 · 9 comments
Milestone

Comments

@GearsAD
Copy link
Contributor

GearsAD commented Mar 27, 2022

As a developer I want access to a 1D fixture that gives me everything I need to perform a simple functional integrated test.

@GearsAD
Copy link
Contributor Author

GearsAD commented Mar 28, 2022

We need to test:

  • Point2 and BearingRange for Tutorial 1
  • ContinuousScalar, LinearRelative, and the various distributions for Tutorial 2
  • Range for Tutorial 3

@dehann dehann self-assigned this Mar 28, 2022
@dehann
Copy link
Member

dehann commented Mar 29, 2022

I'm planning to develop the tests using this code as starting point:

WhereWhenAI/BinderNotebooks#43 (comment)

@jim-hill-r
Copy link
Contributor

My goal originally was to have demos be our regression. With the pivot to Notebooks, we would have to figure out how to run and add assertions to Notebooks. Likely not before ICRA, just a note on the strategy I was attempting to implement.

@jim-hill-r
Copy link
Contributor

I believe this is being worked by Dehann but it is not in progress. Please let me know if I can work it.

@dehann
Copy link
Member

dehann commented Mar 31, 2022

Oh i did not get to this and only noticed @jim-hill-r s post now, sorry about that. Yes please Jim, if you could work this please. I'm going to reassign to you.

I took it on the weekend to help, ended up building the 1D and mixture fixture test. That was the bigger blocker, and actually not 100% up to speed with ideas you might have add for this refactor integration title. So best if you take it please.


Separately, as part of future API standardization etc. I think we should make an upstream test harness repo for the SDKs and then have them all test against that. I'd like to have an Engineering meeting on that first though, just mentioning to socialize my thoughts well in advance :-)

@dehann dehann assigned jim-hill-r and unassigned dehann Mar 31, 2022
@jim-hill-r
Copy link
Contributor

Oh i did not get to this and only noticed @jim-hill-r s post now, sorry about that. Yes please Jim, if you could work this please. I'm going to reassign to you.

K thanks. I'll work it.

Separately, as part of future API standardization etc. I think we should make an upstream test harness repo for the SDKs and then have them all test against that. I'd like to have an Engineering meeting on that first though, just mentioning to socialize my thoughts well in advance :-)

Yes let's do a testing session in engineering soon and document practices in coding-standards.

@jim-hill-r jim-hill-r removed their assignment Apr 1, 2022
@dehann
Copy link
Member

dehann commented Apr 3, 2022

@jim-hill-r , is this needed for Tut1 MVP? Tut1 is not 1D, I take this Issue as technical diligence to build good testing. Looks like you unassigned to rather work this issue as part of Eng discussion on a common upstream testing harness repo for the SDKs?

@jim-hill-r
Copy link
Contributor

I unassigned because I was not working it in favor of other more pressing issues. Feel free to move it or take it as needed.

@dehann
Copy link
Member

dehann commented Apr 4, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants