Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for 1D and Mixture cases. #79

Closed
GearsAD opened this issue Mar 27, 2022 · 2 comments · Fixed by #87
Closed

Tests for 1D and Mixture cases. #79

GearsAD opened this issue Mar 27, 2022 · 2 comments · Fixed by #87
Assignees
Milestone

Comments

@GearsAD
Copy link
Contributor

GearsAD commented Mar 27, 2022

There are not integration tests for these cases and there should be some before we tag this release.

@GearsAD
Copy link
Contributor Author

GearsAD commented Mar 29, 2022

@dehann dehann added this to the v0.4.0 milestone Mar 29, 2022
@dehann
Copy link
Member

dehann commented Mar 29, 2022

I'm going to update the commented 1D graph sectionin in test/integration/fixtures.jl to clear this.

What I'm going to recommend medium term, is that we build one test harness repo for the SDKs, using the pre-existing standardized API as best we can, and then use that as an upstream repo for CI on all the SDKs. That way, if we change something in the test, then all the SDKs will see the change and we can fix accordingly.

Think this issue could benefit from the test harness repo too:

dehann added a commit that referenced this issue Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants