Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public/icon.png not being used for php artisan native:build #388

Open
DeanWard opened this issue Oct 15, 2024 · 1 comment · May be fixed by NativePHP/electron#106
Open

public/icon.png not being used for php artisan native:build #388

DeanWard opened this issue Oct 15, 2024 · 1 comment · May be fixed by NativePHP/electron#106
Labels
bug Something isn't working

Comments

@DeanWard
Copy link

DeanWard commented Oct 15, 2024

What were you trying to do?

Build application for distribution to users

What happened?

The app was built and signed but it uses the default NativePHP icon

How to reproduce the bug

Add a PNG icon.png to your public folder and run php artisan native:build

Package Versions

{
  "installed": [
    {
      "name": "nativephp/electron",
      "direct-dependency": true,
      "homepage": "https://github.com/nativephp/electron",
      "source": "https://github.com/NativePHP/electron/tree/0.7.3",
      "version": "0.7.3",
      "description": "Electron wrapper for the NativePHP framework.",
      "abandoned": false
    },
    {
      "name": "nativephp/laravel",
      "direct-dependency": false,
      "homepage": "https://github.com/nativephp/laravel",
      "source": "https://github.com/NativePHP/laravel/tree/0.5.7",
      "version": "0.5.7",
      "description": "Laravel wrapper for the NativePHP framework.",
      "abandoned": false
    },
    {
      "name": "nativephp/php-bin",
      "direct-dependency": false,
      "homepage": "https://nativephp.com",
      "source": "https://github.com/NativePHP/php-bin/tree/0.5.4",
      "version": "0.5.4",
      "description": "PHP binaries used by the NativePHP framework",
      "abandoned": false
    }
  ]
}

PHP Version

8.2.0

Laravel Version

11.0

Node Version

20.10.0

Which operating systems have you seen this occur on?

macOS

OS version

macos 15.0

Notes

/vendor/nativephp/electron/resources/js/resources/icon.png has the correct icon file (my icon) but after build the app has the default icon. I've clean my icon cache in macos. The correct icon is used for php artisan native:serve.

@DeanWard DeanWard added the bug Something isn't working label Oct 15, 2024
@simonhamp
Copy link
Member

This is coming in NativePHP/electron#106 (see this line)

@simonhamp simonhamp linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants