Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable copy-pasting path into import file picker #7150

Open
CarePackage17 opened this issue Nov 4, 2024 · 5 comments
Open

Enable copy-pasting path into import file picker #7150

CarePackage17 opened this issue Nov 4, 2024 · 5 comments
Assignees
Labels
Feature: GUI Status: Internal This is being tracked internally by the Ghidra team

Comments

@CarePackage17
Copy link

CarePackage17 commented Nov 4, 2024

I often look for binaries with the OS file explorer first, but if I then want to import a file into Ghidra, I have to do the entire navigation again within the file picker window.

The file picker has a sort of address bar, just let me paste into it like I can with Windows Explorer or Nautilus on Ubuntu.

Edit: I just noticed drag and drop works from Nautilus (it can be finicky on Linux sometimes), so...maybe it's not a super critical issue.

@dragonmacher
Copy link
Collaborator

You should be able to paste a path into the "File name: " text field and then press Enter. This will then move the chooser to that directory.

@CarePackage17
Copy link
Author

Yeah that works, though it's a little confusing from a UX perspective.

Is there anything that precludes the file picker's location textbox working that way (like hardcoded assumptions in the UI framework or something)?

@dragonmacher
Copy link
Collaborator

Is there anything that precludes the file picker's location textbox working that way

Nope. The file chooser UI was modeled after something in Windows XP. Hard to believe, but it really hasn't changed much since then.

@CarePackage17
Copy link
Author

If I wanted to take a stab at making this a thing, where would I find the code?

@dragonmacher
Copy link
Collaborator

The class is docking.widgets.filechooser.GFileChooser. The code itself is probably not very difficult. Trickier is dealing with the multithreaded nature of the filechooser. It can be tricky to get that right. There are a ton tests that you can run to verify you did't break anything.

@ryanmkurtz ryanmkurtz added Feature: GUI Status: Triage Information is being gathered Status: Internal This is being tracked internally by the Ghidra team and removed Status: Triage Information is being gathered labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: GUI Status: Internal This is being tracked internally by the Ghidra team
Projects
None yet
Development

No branches or pull requests

3 participants