Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1822 - clean up used undeclared dependencies #1826

Closed
wants to merge 3 commits into from

Conversation

cogross
Copy link
Collaborator

@cogross cogross commented Jan 26, 2023

Added missing "Used Undeclared" dependencies in the pom.xml files across the modules.

Confirm by running: mvn dependency:analyze in the root project directory, and check the output to ensure there are no "used undeclared" dependencies.

Copy link
Collaborator

@apmoriarty apmoriarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general dependency versions should be defined as properties in the top level pom. In cases were a module was using a different dependency version, please document those in a new issue so we can work through those diffs.

@cogross cogross force-pushed the 1822-clean-maven-dependencies branch 2 times, most recently from d679db0 to d4a1524 Compare March 14, 2023 18:27
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch from d4a1524 to ca09773 Compare March 22, 2023 15:14
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch from ca09773 to 8cb831e Compare April 3, 2023 13:02
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch 2 times, most recently from 021ddbe to 11b00f6 Compare April 12, 2023 13:13
Copy link
Collaborator

@jwomeara jwomeara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this. Overall I think this is a step in the right direction, but I had a few comments. Sorry for the duplicate comments across files - I just wanted to make sure I marked each file where I saw that issue.

warehouse/core/pom.xml Outdated Show resolved Hide resolved
warehouse/data-dictionary-core/pom.xml Show resolved Hide resolved
warehouse/edge-dictionary-core/pom.xml Outdated Show resolved Hide resolved
warehouse/ingest-configuration/pom.xml Outdated Show resolved Hide resolved
warehouse/ingest-core/pom.xml Outdated Show resolved Hide resolved
web-services/model/pom.xml Outdated Show resolved Hide resolved
web-services/modification/pom.xml Outdated Show resolved Hide resolved
web-services/query-websocket/pom.xml Outdated Show resolved Hide resolved
web-services/query/pom.xml Outdated Show resolved Hide resolved
web-services/security/pom.xml Outdated Show resolved Hide resolved
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch 5 times, most recently from 5eb56f0 to c85694d Compare August 31, 2023 18:31
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch from c85694d to 9f92ec7 Compare September 8, 2023 15:58
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch 2 times, most recently from 85b1fe7 to 9158d70 Compare October 5, 2023 14:52
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch from 9158d70 to 22c7803 Compare October 13, 2023 11:58
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch 3 times, most recently from b2aba63 to 70bf14d Compare October 25, 2023 16:34
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch 2 times, most recently from 87ce9da to aaa1a40 Compare November 7, 2023 12:20
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch 4 times, most recently from 6cbb63c to 02b5726 Compare November 16, 2023 16:40
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch 5 times, most recently from 172a3d4 to 5672932 Compare December 1, 2023 11:40
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch from 5672932 to c668c63 Compare December 5, 2023 11:57
@cogross cogross force-pushed the 1822-clean-maven-dependencies branch from d0add81 to 68ce05c Compare January 4, 2024 12:11
@cogross
Copy link
Collaborator Author

cogross commented Feb 14, 2024

Closing -- handled in the dependency analysis ticket
#2144

@cogross cogross closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants