-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1822 - clean up used undeclared dependencies #1826
Conversation
7869f41
to
e15da54
Compare
e15da54
to
63d01c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general dependency versions should be defined as properties in the top level pom. In cases were a module was using a different dependency version, please document those in a new issue so we can work through those diffs.
d679db0
to
d4a1524
Compare
d4a1524
to
ca09773
Compare
ca09773
to
8cb831e
Compare
021ddbe
to
11b00f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to do this. Overall I think this is a step in the right direction, but I had a few comments. Sorry for the duplicate comments across files - I just wanted to make sure I marked each file where I saw that issue.
5eb56f0
to
c85694d
Compare
c85694d
to
9f92ec7
Compare
85b1fe7
to
9158d70
Compare
9158d70
to
22c7803
Compare
b2aba63
to
70bf14d
Compare
87ce9da
to
aaa1a40
Compare
6cbb63c
to
02b5726
Compare
172a3d4
to
5672932
Compare
5672932
to
c668c63
Compare
d0add81
to
68ce05c
Compare
Closing -- handled in the dependency analysis ticket |
Added missing "Used Undeclared" dependencies in the pom.xml files across the modules.
Confirm by running:
mvn dependency:analyze
in the root project directory, and check the output to ensure there are no "used undeclared" dependencies.