-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show only mainConceptScheme in hierarchy #1540
base: skosmos-2
Are you sure you want to change the base?
Conversation
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1540 +/- ##
============================================
- Coverage 70.33% 70.25% -0.09%
Complexity 1669 1669
============================================
Files 32 32
Lines 4305 4310 +5
============================================
Hits 3028 3028
- Misses 1277 1282 +5 ☔ View full report in Codecov by Sentry. |
Hi Osma. Thanks a lot for considering our need. |
d1c848f
to
51eb5c0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I rebased the I also tested this with the new data from #1540 (comment) .
This is how the top-level hierarchy looks now: If I open ENVIRONMENT and then water management, I get this: Apart from minor styling (colors etc.) this matches pretty much exactly what @saubin78 requested. However, if I open a specific concept such as "water management", the hierarchy doesn't open at the correct point as it should. Also the "INRAE Thesaurus" is now again appearing at the bottom, after all domains: But at least this is getting closer, right? Regarding further development: We just released Skosmos 2.17, most likely the last release in the Skosmos 2 series; thus, it is unlikely that this pull request will be merged and included in a release. Even if this PR might fix things in your case, I believe it may have side effects on other vocabularies. We are now focusing on Skosmos 3 development. You can of course keep running Skosmos 2 as long as you want, and you can use the code on this branch if that's helpful. More generally, I think we need better specifications for how the hierarchy should look like in Skosmos 3 and how it should behave in different scenarios. I will open a new issue for specifying complex behaviours and configuration of the hierarchy. INRAE Thesaurus is certainly a complicated case and should be considered as an example. |
Reasons for creating this PR
Attempt to fix #1396 i.e. make it possible to limit the hierarchy display to a single ConceptScheme by setting
skosmos:mainConceptScheme
in the vocabulary configuration.I tried loading the INRAE Thesaurus (version without dc:subject triples for microthesauri from @saubin78's comment #1396 (comment)) into a local Fuseki and configured it like this in
config.ttl
:This is how the hierarchy looks like when I go to http://localhost/Skosmos2/inrae/en/?clang=fr and open the Hierarchy tab:
I must say I'm a little confused by the structure in the INRAE Thesaurus. It seems to me that you have two kinds of top concepts under the main concept scheme ("INRAE Thesaurus"): the numbered ones that seem to be topical divisions (e.g. "01. ENVIRONNEMENT") as well as what look like regular concepts intended for subject indexing (e.g. "abattage de bétail"). So Skosmos will display them both. Is this what you intended @dipso-num4sci @saubin78?
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Not sure that I handled all cases. For instance, is the hierarchy correct when opening a concept page directly via URL?
This may affect other vocabularies with more than one ConceptScheme. For example IPTC and all the YSO based domain ontologies in Finto. Careful testing has to be done before merging so that we don't break existing usage of these.
Checklist
.sr-only
class, color contrast)