Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for universal log message verbosity #451

Open
AhtiAhde opened this issue Nov 10, 2020 · 3 comments
Open

Need for universal log message verbosity #451

AhtiAhde opened this issue Nov 10, 2020 · 3 comments
Milestone

Comments

@AhtiAhde
Copy link

There are big differences between log message verbosity of different models.

This problem is probably caused due to the fact that annif doesn't filter the messages in any way, but merely directly passes everything the original process produces (at least this seems to be the case for Omikuji).

In production environment this can cause at least two distinct problems:
-Upon container start, the Maui model is mostly silent, but Omikuji floods all kinds of messages; while this is not dangerous it can look daunting for someone new to the project and sometimes it is easy to forget while debugging other bugs, which can cause doubts targeting to wrong candidates
-When training the models, Omikuji floods warnings that depend on the size of the data set. This can cause the training to fail to exceeding the log size, rather than real error or continuing regardless of warnings; it would be better that these warnings would be aggregated and an explicit "maximum allowed warnings" might generate an error rather than the exceeding of logs.

There are probably more problems, but in general it might be nice that annif would provide some universal log messages / steps of processing, that would be easy and coherent to follow and then give the user ability to add deeper levels of logging, which would allow more streamlined access to the original warnings etc. provided by the underlying models.

@osma osma added this to the Long term milestone Feb 14, 2022
@juhoinkinen
Copy link
Member

  • Upon container start, the Maui model is mostly silent, but Omikuji floods all kinds of messages; while this is not dangerous it can look daunting for someone new to the project and sometimes it is easy to forget while debugging other bugs, which can cause doubts targeting to wrong candidates

Related to this: when Annif is starting, especially in a container environment when one is just looking a log stream, there is no very clear indication that all models are already loaded and Annif is ready to serve requests. It could happen that the Pod or container for Annif is killed for some reason, and I think this is not visible in the logs.

There could be an info message from Annif like Model(s) loaded. when all models are ready, if not a message for every individual model.

@osma
Copy link
Member

osma commented Feb 7, 2023

There could be an info message from Annif like Model(s) loaded. when all models are ready, if not a message for every individual model.

...and now we have an implementation of this in PR #671 😄

@juhoinkinen
Copy link
Member

A step toward this was implemented in #721 for TensorFlow logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants