Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails Caveats Around Spring #10

Open
cguess opened this issue Jul 6, 2021 · 6 comments
Open

Add Rails Caveats Around Spring #10

cguess opened this issue Jul 6, 2021 · 6 comments

Comments

@cguess
Copy link

cguess commented Jul 6, 2021

I think it would be a good idea to add instructions for Rails users (just to be nice), which involves removing Spring as referenced here by @jcupitt.

I can do submit a PR for this, but just wanted to make sure everyone is cool with it?

@Nakilon
Copy link
Owner

Nakilon commented Jul 6, 2021

I think it's more like a ruby-vips problem. There are many other gems that depend on it.

@jcupitt
Copy link

jcupitt commented Jul 6, 2021

Yes, I could well be wrong, it was just a guess. You'd need to test disabling spring, and perhaps ask a spring or senior rails dev for their opinion.

AvtiveStorage itself uses ruby-vips for image handling, so I'd expect this to be a fairly well-known issue.

@cguess
Copy link
Author

cguess commented Jul 8, 2021

@jcupitt Disabling spring does, in fact, fix this issue. It may be a ruby-vips issue but from my perspective it seems like a good idea to at least note it in the set up.

@jcupitt
Copy link

jcupitt commented Jul 8, 2021

Ah, sorry, I hadn't realized. I agree, it's worth noting then.

I wonder how activestorage dodges this issue? I suppose it must delay init until requests come in.

@cguess
Copy link
Author

cguess commented Jul 9, 2021

I'll ask over in the rails forums and update here when I hear more, because, yes, this seems like an interesting problem.

In the mean time expect a PR to the docs for this.

@jcupitt
Copy link

jcupitt commented Jul 14, 2021

Hello all, I think Kleis might have found the problem (or part of it) -- macOS is missing sched_getattr and this forces glib to start threads sooner.

libvips/php-vips-ext#42 (comment)

I've pushed a change to the head of 8.11 to delay thread startup a bit longer, and this might fix this. Would anyone be able to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants