Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zoning hyperlinks for sections of DCP website #997

Open
hannahkates opened this issue Aug 26, 2020 · 2 comments · May be fixed by #1028
Open

Update zoning hyperlinks for sections of DCP website #997

hannahkates opened this issue Aug 26, 2020 · 2 comments · May be fixed by #1028

Comments

@hannahkates
Copy link
Contributor

hannahkates commented Aug 26, 2020

Paul Power noticed that the link in Zola for C3 or C3A from a searched tax lot result pane provides a broken link. Instead of going to https://www1.nyc.gov/site/planning/zoning/districts-tools/c3-c3a.page it uses the following broken link https://www1.nyc.gov/site/planning/zoning/districts-tools/c3.page.

Code is here: https://github.com/NYCPlanning/labs-zola/blob/develop/app/models/map-features/lot.js#L532-L544

@allthesignals
Copy link
Collaborator

It looks like this works for the regular C3 view.

I can see if there's some redundancy in the lookup logic...

@allthesignals
Copy link
Collaborator

Ideally, the tax lot model would have a reference to the appropriate zoning district model...

Doing some archeological work: looks like we added some logic to the zoning district view to handle the idiosyncratic URL scheme of DCP zoning district pages, see this commit.

There are further examples of this: 889cd2d

We should probably have a lookup for these things, with sane defaults... going to work on that.

@allthesignals allthesignals linked a pull request Oct 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants