-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS: Figure out Storybook + Figma designs plug-in #28
DS: Figure out Storybook + Figma designs plug-in #28
Comments
Background on Storybook and how components work
|
Storybook + Figma Compatibilitystorybook + figma, how it works
we are using Storybook 7.6.20
for reference: workday's storybook design system, canvas |
so looks like i am now able to embed figma files into storybook so when a user uses storybook to build a ui component, they can have a live design there. the next step is to see if i can get the figspec compatibility to work which would allow someone to view the design token specs for the figma design within storybook |
got figspec to work, however unable to push changes to my branch since it does use my figma personal access token and github blocked the push (can bypass if i choose to unblock the secret) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
to get
seems worth trying in ur branch! |
related to the
you should probably change it to |
sounds good! i think for figma designs plug in i didn't really run into that issue but i am currently running to issues with the design token plug ins so i'll see it that fixes that! |
Design Token Automation
|
@jessicashanshanhuang happy to help with that! if other significant parts of Storybook + Figma compatibility are working though, might be nice to document/finalize those and break out token automation into it's own issue? but if tokens are already an integral part of the DS in figma, could totally see why token automation should be an expectation of Storybook + Figma compatibility! |
OutcomeThe storybook designs plug-in is implemented in the
Next Steps: Next, we will explore the design token automation pipeline to sync simultaneously update design tokens between figma and storybook. Discussion related to this will be in a new git issue. |
This comment has been minimized.
This comment has been minimized.
updated md is now in |
reopened to initiate pull request for
|
This comment has been minimized.
This comment has been minimized.
figma chakra ui kit is now linked with storybook components! published in latest commit in notes:
next steps: creating a shared personal access token |
This comment has been minimized.
This comment has been minimized.
PR initiated, waiting on review! update: looks like there's some dependency issues, will debug update 2: looks like we have some peer dependency issues, damon and i plan to create two prs: one to upgrade storybook to latest v7 and another to include the design plug with our upgraded version |
storybook v7 PR now ready to review
|
This comment has been minimized.
This comment has been minimized.
Update: Storybook v7 Pr merged, last step is to finish up draft pr for designs plug-in |
Figuring out how to incorporate Storybook + Figma plug-in
Currently: prepping pull request to merge design plugin changes to
main
streetscape repo
my current branchImportant
Currently using
designs-plugin
branch, for documentation, check out designs plug in guide indesign
repoThe text was updated successfully, but these errors were encountered: