Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement find agencies endpoint #288

Merged
merged 2 commits into from
May 24, 2024
Merged

Implement find agencies endpoint #288

merged 2 commits into from
May 24, 2024

Conversation

pratishta
Copy link
Contributor

Closes #244

@pratishta pratishta force-pushed the 244-implement-findAgencies-endpoint branch from bbb4a84 to 5b29e0d Compare May 22, 2024 17:54
@pratishta pratishta marked this pull request as ready for review May 23, 2024 13:45
@pratishta pratishta requested review from TangoYankee and a team May 23, 2024 13:45
TangoYankee
TangoYankee requested changes May 23, 2024
View reviewed changes
src/schema/agency.ts Show resolved Hide resolved
@pratishta pratishta mentioned this pull request May 23, 2024
Closed
1 task
@pratishta pratishta force-pushed the 244-implement-findAgencies-endpoint branch from 5b29e0d to 3497d27 Compare May 23, 2024 19:33
TangoYankee
TangoYankee requested changes May 23, 2024
View reviewed changes
Copy link
Member

@TangoYankee TangoYankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove undefined from the repo return type

  2. consolidate to one commit

  • (optionally: Consolidate to two commits- one for the kubb generated content and a second for the actual endpoint)

Great work!

src/agency/agency.repository.ts Outdated Show resolved Hide resolved
pratishta added 2 commits May 24, 2024 08:44
@pratishta
Add implementation and some tests
b710a11 
Add route

Fix unit test

Add e2e agency test

Add migration

Fix 500 test description and findMany always returns defined obj
@pratishta
Regenerate types and zod schemas
3d4420f
@pratishta pratishta force-pushed the 244-implement-findAgencies-endpoint branch from 3497d27 to 3d4420f Compare May 24, 2024 12:44
@pratishta pratishta merged commit 6cad4ba into main May 24, 2024
3 checks passed
@pratishta pratishta mentioned this pull request May 29, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhochbaum-dcp dhochbaum-dcp dhochbaum-dcp left review comments

@TangoYankee TangoYankee TangoYankee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement findAgencies endpoint
3 participants
@pratishta @TangoYankee @dhochbaum-dcp