Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

391/refac cap fund to remove enums #394

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

horatiorosa
Copy link
Contributor

@horatiorosa horatiorosa commented Nov 26, 2024

Description

drop enums, update types from enum to text, add constraints
- in capital-project-fund
- in capital-commitment-fund
- includes new migration

TIckets

Closes #391

@horatiorosa horatiorosa force-pushed the 391/refac-cap-fund-to-remove-enums branch from 5446fc4 to 56b2f59 Compare November 26, 2024 21:01
@horatiorosa
Copy link
Contributor Author

merge and rebase after 389 is in main

@horatiorosa horatiorosa marked this pull request as ready for review December 2, 2024 19:20
TangoYankee
TangoYankee previously approved these changes Dec 3, 2024
 - in capital-project-fund
 - in capital-commitment-fund

Closes #391
@horatiorosa horatiorosa dismissed TangoYankee’s stale review December 4, 2024 15:28

The merge-base changed after approval.

@horatiorosa horatiorosa force-pushed the 391/refac-cap-fund-to-remove-enums branch from 56b2f59 to 73c417b Compare December 4, 2024 15:28
@horatiorosa horatiorosa self-assigned this Dec 4, 2024
@horatiorosa horatiorosa merged commit 273fc6d into main Dec 5, 2024
3 checks passed
@horatiorosa horatiorosa deleted the 391/refac-cap-fund-to-remove-enums branch December 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor capital fund category from enum to check constraint
2 participants