Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undefined as return type option for findMany #298

Closed
2 tasks
pratishta opened this issue May 29, 2024 · 0 comments · Fixed by #310
Closed
2 tasks

Remove undefined as return type option for findMany #298

pratishta opened this issue May 29, 2024 · 0 comments · Fixed by #310
Assignees
@horatiorosa
Labels
good first issue Good for newcomers

Comments

@pratishta
Copy link
Contributor

The findMany() method returns an array so we should always expect a defined return object. Since we often use these domains as a reference when writing new schemas or endpoints, it's best to update them as soon as we clock an improvement. Reference comment

Acceptance criteria

  • Remove from land-use.repository.ts
  • Remove from borough.repository.ts
@pratishta pratishta added the good first issue Good for newcomers label May 29, 2024
horatiorosa added a commit that referenced this issue Jun 7, 2024
@horatiorosa
298 Removed undefined as option for findMany from:
f663eaa 
 - land-use.repository
 - boroughs.repository

Closes #298

	modified:   src/land-use/land-use.repository.ts
@horatiorosa horatiorosa mentioned this issue Jun 7, 2024
Merged
horatiorosa added a commit that referenced this issue Jun 7, 2024
@horatiorosa
298 Removed undefined as option for findMany from:
8665bd7 
 - land-use.repository
 - boroughs.repository

Closes #298

	modified:   src/land-use/land-use.repository.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@horatiorosa horatiorosa

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

298 Removed undefined as option for findMany from: NYCPlanning/ae-zoning-api
2 participants
@pratishta @horatiorosa