Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow name property for agency to be nullable in Open Api documentation #290

Closed
1 task
pratishta opened this issue May 23, 2024 · 0 comments
Closed
1 task
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@pratishta
Copy link
Contributor

pratishta commented May 23, 2024

Description

The name field on the agency schema is allowed to be null in the database. In the Open API schema where we define this property, we currently only allow it to be of type string. When we generate the types and zod schemas from the Open API documentation, the agency type and schema won't be able to have a null value either, resulting in an endpoint implementation that sends a response that's inconsistent with the database type definition.

Relevant context: #288 (comment)

Acceptance criteria

  • Set nullable to true for name property on agency open api schema
@pratishta pratishta added the documentation Improvements or additions to documentation label May 23, 2024
@pratishta pratishta self-assigned this May 23, 2024
@pratishta pratishta closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant