Wrong beta_D coefficient for VP during sampling?

[qiyan98]

Hi,

There seems to be a bug in the sampler script.

edm/generate.py

Line 88 in b2a26c9

vp_def = vp_sigma(beta_d=19.1, beta_min=0.1)(t=epsilon_s)

edm/generate.py

Line 91 in b2a26c9

vp_def = vp_sigma(beta_d=19.1, beta_min=0.1)(t=1)

I suppose the beta_D coefficient should be 19.9.

Best,
Qi

[qiyan98]

Also, the anonymous function sigma(t) seems not defined in this line:

edm/generate.py

Line 80 in b2a26c9

vp_sigma_deriv = lambda beta_d, beta_min: lambda t: 0.5 * (beta_min + beta_d * t) * (sigma(t) + 1 / sigma(t))

I suppose it's referring to the one defined below:

edm/generate.py

Line 123 in b2a26c9

sigma = vp_sigma(vp_beta_d, vp_beta_min)