Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PBRify_Remix workflow + information #4

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Conversation

Kim2091
Copy link
Contributor

@Kim2091 Kim2091 commented Sep 2, 2024

This PR is to fix some basic issues in the workflow & condense it a bit. Additionally, it adds a link to detailed steps to set up and use the PBRify_Remix workflow.

Thank you very much for adding support initially 🙂

@nxkb
Copy link
Collaborator

nxkb commented Sep 5, 2024

No worries, and thanks for updating it! We fixed our CLA bot, would you mind the CLA for us? (you can just make a comment)

@nxkb nxkb self-requested a review September 5, 2024 00:30
@Kim2091
Copy link
Contributor Author

Kim2091 commented Sep 5, 2024

Hi, thank you for the response. I'm not really sure how to do the CLA? Sorry haha

@nxkb
Copy link
Collaborator

nxkb commented Sep 5, 2024

ah I was hoping a comment would trigger it, but I think you may have to rebase your changes and it should post instructions on here.

Copy link

github-actions bot commented Sep 5, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Kim2091
Copy link
Contributor Author

Kim2091 commented Sep 5, 2024

I have read the CLA Document and I hereby sign the CLA

@nxkb nxkb requested a review from sjgillard September 6, 2024 23:15
Copy link
Collaborator

@sjgillard sjgillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playing around with it seems to work well, and the docs look good to me!

@nxkb nxkb merged commit 702dcc2 into NVIDIAGameWorks:main Sep 7, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants