Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Action for Publishing to Comfy Registry #1

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

robinjhuang
Copy link
Contributor

@robinjhuang robinjhuang commented Aug 16, 2024

This PR adds a Github Action (publish-node-action) that will publish an updated version of your custom node to the registry whenever the pyproject.toml file changes. The pyproject.toml defines the custom node version you want to publish (added in another PR).

Action Required:

  • Make sure the trigger branch (master or main) in publish.yaml matches the branch you want to use as the publishing branch. It will only trigger when the pyproject.toml gets updated on that branch.
  • Create an api key on the Registry for publishing from Github. Instructions.
  • Add it to your Github Repository Secrets as REGISTRY_ACCESS_TOKEN.

Please message me on Discord at haohao_81202 or join our server server if you have any questions!

Copy link

github-actions bot commented Sep 5, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@nxkb nxkb self-requested a review September 5, 2024 00:13
Copy link
Collaborator

@nxkb nxkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@nxkb
Copy link
Collaborator

nxkb commented Sep 5, 2024

@robinjhuang can you just sign our CLA so we can get this merged? Thanks :)

@robinjhuang
Copy link
Contributor Author

What CLA are you talking about?

@svc-remix-github
Copy link
Collaborator

svc-remix-github commented Sep 5, 2024

@nxkb was referring to our Contributors License Agreement. It's a doc that explains details about your contributions (this PR) to this open source project. In order to 'sign' the CLA, you just follow the instructions from this PR comment:

#1 (comment)

@nxkb
Copy link
Collaborator

nxkb commented Sep 6, 2024

@robinjhuang

@nxkb was referring to our Contributors License Agreement. It's a doc that explains details about your contributions (this PR) to this open source project. In order to 'sign' the CLA, you just follow the instructions from this PR comment:

#1 (comment)

@nxkb
Copy link
Collaborator

nxkb commented Sep 10, 2024

Hi @robinjhuang, can you comment the following on this PR to sign our CLA?

I have read the CLA Document and I hereby sign the CLA

@robinjhuang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@robinjhuang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@nxkb nxkb merged commit 3ca1527 into NVIDIAGameWorks:main Sep 24, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants