Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

where is the denoiser? #227

Closed
NileZhou opened this issue Jun 27, 2019 · 13 comments · May be fixed by #240
Closed

where is the denoiser? #227

NileZhou opened this issue Jun 27, 2019 · 13 comments · May be fixed by #240

Comments

@NileZhou
Copy link

in file inference.ipynb,
`ModuleNotFoundError Traceback (most recent call last)
in ()
16 from train import load_model
17 from text import text_to_sequence
---> 18 from denoiser import Denoiser

ModuleNotFoundError: No module named 'denoiser'`

if the denoiser is in apex or other python models?

@akshitmittal1
Copy link

denoiser is a .py file in the repository itself.

@NileZhou
Copy link
Author

denoiser is a .py file in the repository itself.

thanks. but I still don't understand, i can't find the file in tacotron2

@akshitmittal1
Copy link

okay, I don't know why is that happening but you can just copy its code and make a .py file denoiser itself to make it work

@vikrantsharma7
Copy link

vikrantsharma7 commented Jun 28, 2019

It's in the waveglow repo.
sys.path.append('waveglow/')

If still not found

cd waveglow/
git pull origin master

@NileZhou
Copy link
Author

It's in the waveglow repo.
sys.path.append('waveglow/')

If still not found

cd waveglow/
git pull origin master

thanks, i just delete the code to avoid it, with out denoiser, i can generate voice by using nvidia's pre-trained model. however, my training's train loss is always oscillation around 0.4

@rafaelvalle
Copy link
Contributor

Remember to run Initialize submodule: git submodule init; git submodule update
Assuming you have the same setup as the one in this implementation, you need to anneal the learning rate to further decrease the loss.

@orena1
Copy link

orena1 commented Jul 14, 2019

Thanks @rafaelvalle but I think that in the waveglow submodule Denoiser is not there:
https://github.com/NVIDIA/waveglow/tree/4b1001fa3336a1184b8293745bb89b177457f09b

@vikrantsharma7
Copy link

The denoiser was added after the commit you mention.
Pull the latest master branch and you will find it.

@orena1
Copy link

orena1 commented Jul 15, 2019

I understand @vikrantsharma7 but as far as I see the git of tactron2 points to this commit
image

@vikrantsharma7
Copy link

Yes, it does and it hasn't been updated to use a commit that includes the denoiser, so you will need to manually pull it, or run inference without the denoiser.

@SomeUserName1
Copy link

can confirm that after
git submodule init; git submodule update
one needs also to
git pull origin master; git checkout 6188a1d106a1060336040db82f464d6441f39e21
(If you dont checkout this commit there will be an AttributeError object NM does not have attribute cond_layer)
further the pretrained waveglow weights file needs to be renamed (cut off the _ljs_vX.pt)
Then it should work out of the box

@v-nhandt21
Copy link

I have a same problem, have you solve this, thank you

@ColeMurray
Copy link

Experienced the above issue. @SomeUserName1 suggestion to pull in the latest resolved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants