Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for arm64 in build scripts #1958

Closed
jlowe opened this issue Apr 11, 2024 · 2 comments
Closed

Support for arm64 in build scripts #1958

jlowe opened this issue Apr 11, 2024 · 2 comments
Assignees
@NvTimLiu
Labels
build

Comments

@jlowe
Copy link
Member

jlowe commented Apr 11, 2024

The scripts under build/ do not work for ARM builds. There is a Dockerfile.multi which appears to be unreferenced (at least in this repo) that has some support for ARM, and it's unclear why that file is separate from Dockerfile if it supports building images across multiple architectures. Ideally build/build-in-docker and build/run-in-docker would work on both x64 and arm64 machines.
@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Apr 17, 2024 •
edited
Loading

I'll handle this issue later.

@NvTimLiu NvTimLiu assigned NvTimLiu and unassigned GaryShen2008 Apr 17, 2024
@NvTimLiu NvTimLiu mentioned this issue Jul 9, 2024
Merged
@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Jul 9, 2024

Fixed by #2010

@NvTimLiu NvTimLiu closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NvTimLiu NvTimLiu

Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jlowe @mattahrens @GaryShen2008 @NvTimLiu