Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Block pickle loading unless garak’s configured to do unsafe things #989

Open
5 tasks
leondz opened this issue Nov 11, 2024 · 0 comments
Open
5 tasks
Labels
architecture Architectural upgrades
Milestone

Comments

@leondz
Copy link
Collaborator

leondz commented Nov 11, 2024

  • No loading of pickles in garak proper

  • Add test that looks for pickle/cpickle import in garak source and fails if found

  • Disable Hugging Face loading of pickle-based anything unless a CLI flag is present

  • Do not make that CLI flag possible to configure in YAML, so that users must be aware of what's happening each time

  • Add test to make sure CLI flag to enable HF pickle loading doesn't work if placed in YAML

@leondz leondz added the architecture Architectural upgrades label Nov 11, 2024
@leondz leondz added this to the 24.12 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Architectural upgrades
Projects
None yet
Development

No branches or pull requests

1 participant