Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code related to train_valid_test_num_samples may be wrong / unused #176

Open
odelalleau opened this issue May 17, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@odelalleau
Copy link
Collaborator

Describe the bug

NB: this was first noticed by @eloialonso

Code related to train_valid_test_num_samples seems weird -- at least for RM training (I haven't checked other algos):

  • It is unclear what the initialization to [-1 * cfg.model.global_batch_size] * 3 is meant to do (link)
  • It's suspicious that the first element (size of train set) is used when building the validation and test sets (example here)
  • It doesn't even seem to be used in the end (in this function)

=> probably that some code clean-up is needed (?)

@odelalleau odelalleau added the bug Something isn't working label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant