Update manifest and pin newer numpy in containers #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
requested review from
terrykong and
yhtang
and removed request for
terrykong
olupton
changed the title
nouiz
approved these changes
Jan 4, 2024
terrykong
approved these changes
Jan 4, 2024
|
This wasn't caught in the review, but just wanted to ask the next time the patch branches are updated, to mention that in the PR description. It wasn't clear that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #405 the presubmit CI is based on package versions listed in the
manifest.yamlthat is committed to the repository. This has not been updated for ~1 month, so the presubmit CI is testing ~1 month old versions of the ecosystem. This PR updates it using the commit from https://github.com/NVIDIA/JAX-Toolbox/tree/znightly-2024-01-03-7395605285, generated by the nightly CI run.Because this bumps the JAX version by ~1 month, we have to include fixes for deprecations. In particular replacing
jax.random.KeyArraywith plainjax.Array(nvjax-svc-0/t5x@4d5ec2f).The deprecated name is used in older versions of the
chexpackage, which are being selected by pip's dependency resolver despite newer versions being available. We avoid this by giving pip a helping hand and nudging it to use a newernumpyversion, which allows it to select a newerchex. But it's easy to imagine similar issues in future with other packages.Closes #448.