-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pip-compile to help with consistent Python dependency resolution #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Terry Kong <[email protected]>
Created issue to track the VCS installs: #384 @DwarKapex and @yhtang |
terrykong
reviewed
Nov 20, 2023
terrykong
reviewed
Nov 20, 2023
terrykong
reviewed
Nov 20, 2023
terrykong
reviewed
Nov 20, 2023
terrykong
reviewed
Nov 20, 2023
terrykong
reviewed
Nov 20, 2023
terrykong
reviewed
Nov 20, 2023
DwarKapex
approved these changes
Nov 21, 2023
terrykong
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/opt/pip-tools.d
folder to instruct which packages shall be installed by pip-tools. The stage is named due to its similarity in how ingredients in a meal kit are prepared while deferring the final cooking step.ghcr.io/nvidia/image:mealkit
andghcr.io/nvidia/image:mealkit-YYYY-MM-DD
ghcr.io/nvidia/image:latest
andghcr.io/nvidia/image:nightly-YYYY-MM-DD
Additional changes to the workflows
/opt/jax-source
is renamed to/opt/jax
. The-source
suffix is only added to packages that needs compilation, e.g. XLA and TE._build_*.yaml
workflows are simplified to build only one image for a single architecture at a time. The logic for creating multi-arch images is relocated into the_publish_container.yaml
workflows and involved during the nightly runs only.What remains to be done
Reviewing tips
This PR requires a multitude of reviewers due to its size and scope. I'd truly appreciate code owners to review any changes related to their previous contributions. An incomplete list of reviewer-scope is:
Closes #223
Closes #230
Closes #231
Closes #232
Closes #233
Closes #271
Fixes #328
Fixes #337
Co-authored-by: Terry Kong [email protected]