[Reproducible rosetta build] Adds support for building rosetta with local patches and an already generated patch dir #354
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ on: | |
| inputs: | ||
| BASE_IMAGE: | ||
| type: string | ||
| description: 'Upstream Pax mealkit image without $arch-mealkit suffix, e.g., (ghcr.io/nvidia/jax-toolbox-internal:6857094059-upstream-pax). Leaving empty implies ghcr.io/nvidia/upstream-pax:mealkit' | ||
| default: '' | ||
| required: false | ||
| PUBLISH: | ||
|
|
@@ -49,15 +49,6 @@ jobs: | |
| if: steps.if-upstream-failed.outputs.UPSTREAM_FAILED == 'true' | ||
| uses: styfle/[email protected] | ||
|
|
||
| - name: Set build date | ||
| id: date | ||
| shell: bash -x -e {0} | ||
|
|
@@ -77,6 +68,10 @@ jobs: | |
| BASE_IMAGE_ARM64=${{ inputs.BASE_IMAGE }}-arm64-mealkit | ||
| fi | ||
| echo "BASE_LIBRARY=${{ env.BASE_LIBRARY }}" >> $GITHUB_OUTPUT | ||
| # A container should be published if: | ||
| # 1) the workflow is triggered by workflow_dispatch and the PUBLISH input is true, or | ||
| # 2) the workflow is triggered by workflow_run (i.e., a nightly build) | ||
| echo "PUBLISH=${{ github.event_name == 'workflow_run' || (github.event_name == 'workflow_dispatch' && inputs.PUBLISH) }}" >> $GITHUB_OUTPUT | ||
| echo "BASE_IMAGE_AMD64=${BASE_IMAGE_AMD64}" >> $GITHUB_OUTPUT | ||
| echo "BASE_IMAGE_ARM64=${BASE_IMAGE_ARM64}" >> $GITHUB_OUTPUT | ||
|
|
||
|
|
@@ -100,6 +95,29 @@ jobs: | |
| BASE_IMAGE: ${{ needs.metadata.outputs.BASE_IMAGE_ARM64 }} | ||
| secrets: inherit | ||
|
|
||
| publish-build-badge: | ||
| needs: [metadata, amd64, arm64] | ||
| uses: ./.github/workflows/_publish_badge.yaml | ||
| if: always() | ||
| with: | ||
| ENDPOINT_FILENAME: 'rosetta-pax-build-status.json' | ||
| PUBLISH: ${{ needs.metadata.outputs.PUBLISH == 'true' }} | ||
| SCRIPT: | | ||
| if [[ ${{ needs.amd64.result }} == "success" && ${{ needs.arm64.result }} == "success" ]]; then | ||
| BADGE_COLOR=brightgreen | ||
| MSG=passing | ||
| STATUS=success | ||
| else | ||
| BADGE_COLOR=red | ||
| MSG=failing | ||
| STATUS=failure | ||
| fi | ||
| echo "LABEL='nightly'" >> $GITHUB_OUTPUT | ||
| echo "MESSAGE='${MSG}'" >> $GITHUB_OUTPUT | ||
| echo "COLOR='${BADGE_COLOR}'" >> $GITHUB_OUTPUT | ||
| echo "STATUS='${STATUS}'" >> ${GITHUB_OUTPUT} | ||
| secrets: inherit | ||
|
|
||
| publish-mealkit: | ||
| needs: [metadata, amd64, arm64] | ||
| if: needs.metadata.outputs.PUBLISH == 'true' | ||
|
|
@@ -113,8 +131,17 @@ jobs: | |
| type=raw,value=mealkit,priority=500 | ||
| type=raw,value=mealkit-${{ needs.metadata.outputs.BUILD_DATE }},priority=500 | ||
|
|
||
| # TODO: Test ARM when runners available | ||
| test-amd64: | ||
| needs: amd64 | ||
| uses: ./.github/workflows/_test_pax_rosetta.yaml | ||
| with: | ||
| PAX_IMAGE: ${{ needs.amd64.outputs.DOCKER_TAG_FINAL }} | ||
| secrets: inherit | ||
|
|
||
| # TODO: ARM Tests | ||
| publish-final: | ||
| needs: [metadata, amd64, arm64, test-amd64] | ||
| if: needs.metadata.outputs.PUBLISH == 'true' | ||
| uses: ./.github/workflows/_publish_container.yaml | ||
| with: | ||
|
|
@@ -123,49 +150,45 @@ jobs: | |
| ${{ needs.arm64.outputs.DOCKER_TAG_FINAL }} | ||
| TARGET_IMAGE: pax | ||
| TARGET_TAGS: | | ||
| ${{ needs.test-amd64.outputs.TEST_STATUS == 'success' && 'type=raw,value=latest,priority=1000' || '' }} | ||
|
There was a problem hiding this comment. I'd recommend to put this logic in a 'metadata' job/jobstep, and then reference the job/jobstep output for better readability. There was a problem hiding this comment. This depends on test results. |
||
| type=raw,value=nightly-${{ needs.metadata.outputs.BUILD_DATE }},priority=900 | ||
|
|
||
| # TODO: ARM Tests | ||
| publish-test-badge: | ||
| needs: [metadata, publish-build-badge, test-amd64] | ||
| uses: ./.github/workflows/_publish_badge.yaml | ||
|
There was a problem hiding this comment. Note that `_publish_badge.yaml`` will be deprecated soon. There was a problem hiding this comment. Would it be okay to tackle this in a subsequent PR? My thinking is we can get the reproducible build/ci changes out and then circle back to sitrep. I expect the reproducible PRs to all be flushed out within a week or two :) |
||
| if: always() | ||
| secrets: inherit | ||
| with: | ||
| ENDPOINT_FILENAME: 'rosetta-pax-overall-test-status.json' | ||
| PUBLISH: ${{ needs.metadata.outputs.PUBLISH == 'true' }} | ||
| SCRIPT: | | ||
| PAX_STATUS=${{ needs.test-amd64.outputs.TEST_STATUS }} | ||
|
|
||
| echo "LABEL='Tests'" >> $GITHUB_OUTPUT | ||
|
|
||
| STATUS=failure | ||
| if [[ ${{ needs.publish-build-badge.outputs.STATUS }} == "success" ]]; then | ||
| if [[ $PAX_STATUS == "success" ]]; then | ||
| COLOR=brightgreen | ||
| MESSAGE="MGMN passed" | ||
| STATUS=success | ||
| else | ||
| COLOR=red | ||
| MESSAGE="MGMN failed" | ||
| fi | ||
| else | ||
| COLOR="red" | ||
| MESSAGE="n/a" | ||
| fi | ||
|
|
||
| echo "COLOR='${COLOR}'" >> $GITHUB_OUTPUT | ||
| echo "MESSAGE='${MESSAGE}'" >> $GITHUB_OUTPUT | ||
| echo "STATUS='${STATUS}'" >> ${GITHUB_OUTPUT} | ||
|
|
||
| finalize: | ||
| if: always() | ||
| needs: [metadata, amd64, arm64, test-amd64] | ||
| uses: ./.github/workflows/_finalize.yaml | ||
| with: | ||
| PUBLISH_BADGE: ${{ needs.metadata.outputs.PUBLISH == 'true' }} | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that
_publish_badge.yamlwill be deprecated soon.