New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A large amount of memory reserved but unnecessary #236

Open

kurtlau opened this issue Jan 24, 2024 · 1 comment · May be fixed by #237

Assignees

kurtlau commented Jan 24, 2024

PhysX/physx/source/common/src/CmCollection.cpp

Lines 110 to 115 in 85befb6

    
           void Collection::add(PxCollection& _collection) 
        
           { 
        
           	Collection& collection = static_cast<Collection&>(_collection); 
        
           	PX_CHECK_AND_RETURN(this != &collection, "PxCollection::add(PxCollection&) called with itself!"); 
        
           	mObjects.reserve(mObjects.capacity() + collection.mObjects.size());

After add collections for several times, a large amount of memory reserved but unnecessary.

kurtlau linked a pull request

that will close this issue

fix: unecessary memory reserve #237

Open

preist-nvidia assigned sschirm

Collaborator

preist-nvidia commented Jan 26, 2024

Thank you for the report and PR! We'll have a look. Internal tracking: PX-4763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment