Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVN-228 nve-alert Design feedback #46

Closed
knutnve opened this issue Dec 18, 2023 · 2 comments · Fixed by #15
Closed

AVN-228 nve-alert Design feedback #46

knutnve opened this issue Dec 18, 2023 · 2 comments · Fixed by #15
Assignees
@amish1188

Comments

@knutnve
Copy link
Collaborator

knutnve commented Dec 18, 2023

Kommentar:

Vestre-Ikon er ikke likt selv om det er material symbols?
Close icon er ikke likt. Shoelace ikon?
Forskjellig høyde. Men det styres vel av innholdet + 16px padding?
Bodyteksten oppleves som fetere i kode enn design

alert comment

Originally posted by @knutnve in #15 (review)
@knutnve
Copy link
Collaborator Author

knutnve commented Dec 18, 2023

#15 (comment)

@knutnve
Copy link
Collaborator Author

knutnve commented Dec 18, 2023

#15 (comment)

@knutnve knutnve changed the title AVN-228 nve-alert Design Kommentar AVN-228 nve-alert Design feddback Dec 18, 2023
@knutnve knutnve changed the title AVN-228 nve-alert Design feddback AVN-228 nve-alert Design feedback Dec 18, 2023
@knutnve knutnve linked a pull request Dec 18, 2023 that will close this issue
PR: AVN-228 nve-alert #15
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amish1188 amish1188

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR: AVN-228 nve-alert NVE/Designsystem
2 participants
@amish1188 @knutnve