Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStreetMap embed #880

Open
ChildishGiant opened this issue Aug 14, 2024 · 1 comment
Open

OpenStreetMap embed #880

ChildishGiant opened this issue Aug 14, 2024 · 1 comment

Comments

@ChildishGiant
Copy link

I'd love if there was an option for an OpenStreetMap embed over a Google Maps one. I might be able to take a crack at it given that leaflet.js makes things so easy. Just opening this issue to track interest/likelihood of getting merged

@JoeGermuska
Copy link
Member

I'd review a PR for an OSM embed. The key thing we'd want to see is that it's easy for creators to specify -- but OSM map views carry lng/lat/zoom which is the key thing.

When TimelineJS was created, things like including Leaflet were not clear, but now that we have an NPM based build, it could be fairly straightforward. I'm not crazy about bloating the distribution bundle but maybe that won't be a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants